Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimise effects that only exist to return a teardown #11936

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

Rich-Harris
Copy link
Member

There are a number of places where we create effects whose only purpose is to return a teardown function — most notably, every time we create a non-delegated event handler. In these cases we create an unnecessary closure, creating memory overhead, and go through the rigamarole of executing the effect.

It occurred to me that we can optimise this case. Maybe it's an optimisation too far but it seemed like a quick and easy win

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: 66f5ff3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: MotionlessTrain <timothy@familie-de-moor.nl>
@Rich-Harris Rich-Harris merged commit ddb0bc3 into main Jun 7, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the teardown-effects branch June 7, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants