Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort possible bindings in invalid binding error #11950

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

wackbyte
Copy link
Contributor

@wackbyte wackbyte commented Jun 7, 2024

Re: this comment.

Sorts the list of possible bindings in the "bind:xxx is not a valid binding" error message to make it easier to read.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • (sort of) It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: b61aeed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wackbyte wackbyte force-pushed the sort-possible-bindings branch 2 times, most recently from 6cbb17f to 3311293 Compare June 7, 2024 04:52
@Rich-Harris Rich-Harris merged commit c9202a8 into sveltejs:main Jun 8, 2024
6 of 8 checks passed
@Rich-Harris
Copy link
Member

thank you!

@wackbyte wackbyte deleted the sort-possible-bindings branch June 8, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants