Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simpler string normalization #11954

Merged
merged 3 commits into from
Jun 8, 2024
Merged

feat: simpler string normalization #11954

merged 3 commits into from
Jun 8, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jun 7, 2024

It turns out that text.nodeValue = undefined (or null) results in text.nodeValue === '', and in all the places we currently use stringify implicit coercion happens anyway, so:

  • we don't need to use $.stringify when updating text nodes directly (unless it's inside a template literal, where we can just use ?? '')
  • we don't need to use it when setting input values (again, just use ?? '')

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 2971e00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 968bba5 into main Jun 8, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the simpler-normalization branch June 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants