Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle is attribute on elements with spread #12056

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: handle is attribute on elements with spread #12056

merged 1 commit into from
Jun 17, 2024

Conversation

dummdidumm
Copy link
Member

The is attribute is special and always needs to be part of the static template string, or else it wouldn't be taken into account on initialization
fixes #12052

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

The `is` attribute is special and always needs to be part of the static template string, or else it wouldn't be taken into account on initialization
fixes #12052
Copy link

changeset-bot bot commented Jun 17, 2024

🦋 Changeset detected

Latest commit: a30c935

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit a1b6cc6 into main Jun 17, 2024
8 checks passed
@dummdidumm dummdidumm deleted the is-attr branch June 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Customized built-in elements
2 participants