Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow animations to be aborted #1468

Merged
merged 3 commits into from May 16, 2018
Merged

allow animations to be aborted #1468

merged 3 commits into from May 16, 2018

Conversation

Rich-Harris
Copy link
Member

This is another thing that's basically impossible to check with JSDOM. Might add a test to tests/js/samples instead of trying to create a suitable behaviour test.

It fixes #1458, and should also fix #1462, though I haven't tested that yet.

@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #1468 into master will increase coverage by 0.21%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
+ Coverage   91.15%   91.36%   +0.21%     
==========================================
  Files         124      124              
  Lines        4565     4794     +229     
  Branches     1437     1555     +118     
==========================================
+ Hits         4161     4380     +219     
- Misses        160      162       +2     
- Partials      244      252       +8
Impacted Files Coverage Δ
src/compile/nodes/Animation.ts 100% <ø> (+25%) ⬆️
src/compile/nodes/EachBlock.ts 98.15% <100%> (ø) ⬆️
src/compile/nodes/Element.ts 94.29% <100%> (+0.92%) ⬆️
src/compile/dom/Block.ts 91.22% <57.14%> (-2.53%) ⬇️
src/compile/nodes/Slot.ts 93.39% <0%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d2251...8ba809d. Read the comment docs.

@Rich-Harris Rich-Harris changed the title [WIP] allow animations to be aborted allow animations to be aborted May 16, 2018
@Rich-Harris Rich-Harris merged commit a9d258b into master May 16, 2018
@Rich-Harris Rich-Harris deleted the gh-1458 branch May 16, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants