Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stores accept mutable data #2190

Merged
merged 3 commits into from
Mar 9, 2019
Merged

Stores accept mutable data #2190

merged 3 commits into from
Mar 9, 2019

Conversation

Rich-Harris
Copy link
Member

Fixes #2171. TODO implement deep bindings

@codecov-io
Copy link

codecov-io commented Mar 9, 2019

Codecov Report

Merging #2190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2190   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06040d3...093cc0f. Read the comment docs.

@Rich-Harris Rich-Harris marked this pull request as ready for review March 9, 2019 21:57
@Rich-Harris
Copy link
Member Author

Spotted an opportunity to shrink store.mjs while I was at it — readable is now implemented in terms of writable

@Rich-Harris Rich-Harris merged commit 8875fa8 into master Mar 9, 2019
@Rich-Harris Rich-Harris deleted the gh-2171 branch March 9, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants