Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect compiler CSS option in SSR #2360

Closed
wants to merge 2 commits into from
Closed

Conversation

domingues
Copy link

@domingues domingues commented Apr 5, 2019

Don't produce CSS in server side render when the CSS compiler option is set to false.

Don't produce css in server side render when css option is set to false.
@domingues domingues closed this Apr 5, 2019
@domingues domingues reopened this Apr 5, 2019
@domingues domingues changed the title Respect compiler css option in SSR Respect compiler CSS option in SSR Apr 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #2360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2360   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b161725...29f268c. Read the comment docs.

@Rich-Harris
Copy link
Member

Thank you, but this is actually the expected behaviour — css is an option that affects whether styles will be injected with JavaScript in the browser. I don't think there's any benefit to turning this off in SSR mode; you can just ignore result.css.

@Rich-Harris Rich-Harris closed this Apr 6, 2019
@domingues
Copy link
Author

Yes I can ignore the generated css, just thinks that is kind of unnecessary produce something just to ignore it in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants