Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 readme alt #2436

Merged
merged 5 commits into from
Apr 21, 2019
Merged

V3 readme alt #2436

merged 5 commits into from
Apr 21, 2019

Conversation

Rich-Harris
Copy link
Member

Was thinking that with the compiler options etc living in the API docs now, maybe the README could just be this?

Ref #1953

@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #2436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2436   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d71b51...4a79e37. Read the comment docs.

@Conduitry
Copy link
Member

I think it makes sense to just have the compiler API live in one place, and the website is a better place for that than the readme.

I'm less sure about removing the build system plugins and the starter repos. Where is that stuff going to live? If we're going to make an effort to revive https://github.com/sveltejs/awesome, there might make sense.

I agree that talking about npm link doesn't belong here, but I do think we should mention the big main npm run scripts: just build, dev, and test probably.

The test directory could have its own readme honestly, explaining what the different types of tests are for, and about some of the finer points like -g and solo: true (and .solo in directory names) and the update.js scripts. This can happen separately though.

Maybe we could also have a link to the site directory and indicate that that's where the website lives.

Lastly, I'm not thrilled with the text logo at the top of the readme living off in githubusercontent.com somewhere. If it's used in a readme and it's not a badge or something else that needs to be dynamic, I think it should live in the repo.

@Rich-Harris
Copy link
Member Author

All good points, have made a few changes.

I'm less sure about removing the build system plugins and the starter repos. Where is that stuff going to live? If we're going to make an effort to revive https://github.com/sveltejs/awesome, there might make sense.

I think that's a good idea. Though I have to admit that I find the whole 'awesome-xxx' thing incredibly grating — is it important to stick to that convention, or could we call it something like https://github.com/sveltejs/integrations, which feels a bit less 'participation trophy' and a bit more 'useful stuff for adults'?

@Conduitry
Copy link
Member

Ha. I do appreciate some levity in my tech stuff, but I am glad that someone else finds the awesome-xxx thing grating. It's been driven so far into the ground that it doesn't feel remotely like levity anymore even, just another dumb cringe-inducing piece of bullshit tech culture. 😷

Anyway. Svelte is in a lot of ways about bucking conventions. I don't think we should worry about following this one. Having a repo that focuses on collecting integrations in one place (and without doing all of the other stuff that the awesome repo was trying to do) makes sense.

@Conduitry Conduitry mentioned this pull request Apr 18, 2019
@tomcon
Copy link

tomcon commented Apr 18, 2019

agree 'awesome-xxx' should be passed by, but 'integrations' sounds a bit too tame imo
we need an attractive word somewhere inbetween both, here we go again, naming things is hard...

Perhaps use the same word as one of our channels:
Svelte Showcase?

@Conduitry
Copy link
Member

I think there should just be a tame boring list of integrations somewhere, for things like build tool plugins, preprocessor plugins, editor extensions, etc. Having a showcase of cool stuff made with Svelte makes sense, but I think it should be separate.

@pngwn
Copy link
Member

pngwn commented Apr 18, 2019

'quite-good'

@c0bra
Copy link
Contributor

c0bra commented Apr 18, 2019

I personally have no problem with the awesome- prefix. It's my go to when looking for resources for some new tech I start looking at.

Maybe I've been lucky and haven't been hit with the negative side of it. But to me it's literally just a word.

@Rich-Harris
Copy link
Member Author

I've moved sveltejs/awesome over to sveltejs/integrations so I'll merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants