Site: Default Cache-Control value #2476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site has a lot of unspecified Cache-Control values for many files.
For example, all images, SVGs, and fonts had no caching declared. There were also some straggler
.json
and.css|js
files that had no values.It seemed like 10m was the preferred value elsewhere in the site, so I used that as the default value.
To change a file or mark it as not cacheable, you'd set a value elsewhere, (example).
I also verified that the
service-worker.js
maintains itsno-cache, no-store, must-revalidate
setting.