Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Default Cache-Control value #2476

Merged
merged 4 commits into from
Apr 22, 2019
Merged

Site: Default Cache-Control value #2476

merged 4 commits into from
Apr 22, 2019

Conversation

lukeed
Copy link
Member

@lukeed lukeed commented Apr 22, 2019

The site has a lot of unspecified Cache-Control values for many files.

For example, all images, SVGs, and fonts had no caching declared. There were also some straggler .json and .css|js files that had no values.

It seemed like 10m was the preferred value elsewhere in the site, so I used that as the default value.
To change a file or mark it as not cacheable, you'd set a value elsewhere, (example).

I also verified that the service-worker.js maintains its no-cache, no-store, must-revalidate setting.

@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #2476 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2476   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8832f0...85481a4. Read the comment docs.

@lukeed lukeed mentioned this pull request Apr 22, 2019
site/src/server.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants