Dont throw parse error on doctype declaration #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2017 17:16
…ion for doctype tag matching
🤘 🎉 Hadn't even thought about doctype, but this makes total sense. Thanks! Have released version 1.6.5 with this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Svelte gang. I'm trying out svelte for the first time for some server-side rendering and I ran across this bug. I want to note that this is potentially my first open-source contribution. ✊
I am importing
index.htmlvia svelte/ssr/register, but the compiler throws a ParseError on the<!doctype>tag because the regular expression for valid tag names doesn't account for the leading!. For the same reason, "doctype" isn't recognized as a valid void element.It's a pretty simple bug so I hope that this explanation is sufficient.