xmlns should be added as an attribute for consistency #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this one when I was looking at the |
|
From testing in chrome and Firefox it doesn't change a thing.
…On Mon, Jan 23, 2017 at 5:59 PM Conduitry ***@***.***> wrote:
I noticed this one when I was looking at the universal-tests branch the
yesterday. Is this really necessary? Do we need this set as an attribute,
as well as passing it to createElementNS? Does the attribute's presence
affect anything besides the serialization and the client-side unit test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#262 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADWoBDD-5Fr8zZeoVonzbTslqSEKFNGVks5rVT7JgaJpZM4LrnCS>
.
|
|
Yeah, I think this might be something that was necessary in HTML4, maybe — certainly doesn't have any effect on behaviour, so I thought it best to omit it in the name of saving bytes |
|
@Rich-Harris This is needed for SVGs to work on IE10<, which has about 8% browser marketshare at the moment. |
|
Updated to master. |
|
Ah, didn't know that. Worth including in that case — thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #261 I found out that the client code doesn't actually set xmlns as an attribute, resulting in the outputted code to not have a namespace if converted to the string. The server handles this correctly.