add database entries for new gists, update REPL URLs #2680
Conversation
| @@ -6,7 +6,7 @@ exports.up = DB => { | |||
| name character varying(255), | |||
| username character varying(255) not null, | |||
| avatar text, | |||
| github_token character varying(255) not null, | |||
| github_token character varying(255), | |||
There was a problem hiding this comment.
This should be the only change to the production DB required
|
Alright, this is ready if anyone wants to take a look at it. The only other thing I thought about adding is a |
|
I did, yeah — it seems to work correctly |
| let k, cols=[], vals=[]; | ||
| for (k in obj) { | ||
| cols.push(k); | ||
| vals.push(k === 'files' ? JSON.stringify(obj[k]) : obj[k]); |
There was a problem hiding this comment.
Did I write this? Can't tell if this file was moved or is new.
Looking at it, the JSON.stringify shouldn't be necessary... I think
There was a problem hiding this comment.
I added the JSON.stringify, it was erroring without it. I think it'll accept objects but not arrays (I changed the structure to files: [...] instead of files: {...} since we're no longer bound to the gist format, to reduce faffing
There was a problem hiding this comment.
Ah, then okay. Arrays need explicit casting. We could also do { files } so that the input/output is automatic. Just have to remember to row.files.files, which may be too annoying.
There was a problem hiding this comment.
yeah, i wondered about that. i reckon explicit casting is ok, since we probably won't need to add it in more places, and since we'll get a loud error if we do
This builds on #2572:
/repl?gist=xyz123URLs with/repl/xyz123/repl?example=hello-worldURLs with/repl/hello-world/replto/repl/hello-world/gist/createto/repl/create.jsonand/gist/xyz123to/repl/xyz123.jsongiststable of the databaseTurns the fork icon into a link tochanged my mind about this. Instead, it inserts a history entry, so that the back button takes you to the parent/repl/xyz123/fork(which would update the database and redirect the user to/repl/abc234)relaxedlogic