Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder structure #2887

Merged
merged 7 commits into from
May 28, 2019
Merged

Folder structure #2887

merged 7 commits into from
May 28, 2019

Conversation

Rich-Harris
Copy link
Member

This applies the changes discussed in #2790. I think it's a lot neater, and makes life easier in certain ways. For each sub-package (svelte/store, svelte/easing and so on) a stub package.json is created alongside a type declaration file.

The only possible danger here that I can see is that someone is using file extensions:

import { writable } from 'svelte/store.mjs'; // instead of 'svelte/store'

We could keep those files (re-exporting from the new ones, and printing a warning) but it feels like it's probably unnecessary. I can be persuaded if people feel strongly

.gitignore Outdated Show resolved Hide resolved
@Rich-Harris Rich-Harris merged commit 767ce22 into master May 28, 2019
@Rich-Harris Rich-Harris deleted the folder-structure branch May 28, 2019 21:53
@Conduitry
Copy link
Member

This doesn't look like it does the stub package.json files thing. Was that intentional?

@Conduitry Conduitry mentioned this pull request May 29, 2019
@Conduitry
Copy link
Member

Update: prepublishOnly is what creates the stubs, and not build. This is bad and I am going to open a PR to change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants