warn on onrender/onteardown, replace with oncreate/ondestroy #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rich-Harris
changed the title
|
Did this make it into the changelog? I don't see it there |
|
whoops! no, will add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #40. Removing
onrender/onteardownwill be a breaking change, but we can minimise the disruption by deprecating it now (ahead of a version 2 release) in a non-breaking way — i.e. printing a deprecation warning and translating the names behind the scenes. This PR also affords an opportunity for a final round of bikeshedding. Feedback welcome.