Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out each-block code into helper functions #3547

Closed
wants to merge 1 commit into from

Conversation

Swatinem
Copy link
Member

This changes the generated code for EachBlocks into a bunch of helpers, as suggested here: #3504 (comment)

What still needs to be done is everything around animations/transitions and unkeyed updates, but even without it, it is ready now and passes all the current tests.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Swatinem Swatinem self-assigned this Sep 10, 2019
@Swatinem Swatinem mentioned this pull request Sep 10, 2019
4 tasks
@Swatinem
Copy link
Member Author

Still interested in seeing this through, though I didn’t really have the motivation recently to work on it.
Closing for now, will open a new PR if I have something fresh.

@Swatinem Swatinem closed this Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant