Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hoist globals even if they are mentioned in a script block #3745

Merged
merged 1 commit into from
Oct 20, 2019
Merged

hoist globals even if they are mentioned in a script block #3745

merged 1 commit into from
Oct 20, 2019

Conversation

Conduitry
Copy link
Member

I don't really know what sort of test to write for this besides a js sample one, and I'm not really sure what I'd say in the changelog, but this should fix #3607.

@Conduitry
Copy link
Member Author

I was thinking about writing a vars test for this, but those only test against the final return value from the compiler, which already has the globals filtered out. So I'm just going to merge this as is.

@Conduitry Conduitry merged commit 39b387a into sveltejs:master Oct 20, 2019
@Conduitry Conduitry deleted the gh-3607 branch October 20, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with process.env inside props within loops or await blocks
1 participant
@Conduitry