Add bindings for HTMLVideoElement.videoWidth and videoHeight #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brilliant, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds read-only bindings for
videoWidthandvideoHeightto<video>elements. These properties return the intrinsic size of the video, so you can for example resize a<canvas>to match the size of the video:These bindings are updated whenever the
<video>element fires aresizeevent. This caused a small issue, since we were already using the nameresizeinternally to implement dimension bindings. Therefore, I've renamed that internal event toelementresize, so the video bindings can bind to the "regular"resizeevent. This does change the emit for dimension bindings slightly, since the name of the event is used for the generated handler (example).Follow-up on #3650.