also trim whitespace from elseif/else blocks #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.60% (diff: 100%)@@ master #49 diff @@
==========================================
Files 49 49
Lines 1291 1299 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1169 1177 +8
Misses 122 122
Partials 0 0
|
|
Nice, thanks 🍺
It's actually not hugely important, those numbers are only used in error messages, it doesn't affect any functionality. If it's wrong, we can fix it eventually 😀 (but it's probably right) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some else blocks were also missing
endmarkers, so I added some, although I’m not 100% sure those are correct. Also noticed that thestart/endmarkers from trimmed textnodes should maybe reflect the actual text content rather than the whole block?