Only update dynamic subtrees #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snuck in a couple of other improvements, such as getting rid of the |
|
Am getting a bit carried away fixing other things that I see, since these changes touch a few different parts of the codebase — am going to merge this and #489 in before it turns into a complete rewrite... |
Merged
|
2e7a429 *blinks* Well I just learned something new about the order things happen in javascript. |
|
I know right! Was pretty excited when I realised we could do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #489. Blocks representing subtrees that only have static content don't get
updatemethods — less code, and less work.