fix(820): label has associated control #5074

skippednote · 2020-06-26T11:53:04Z

For #820
Because label-has-for has been deprecated I have instead implemented label-has-associated-control.

Before submitting the PR, please make sure you do the following

It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

Run the tests with npm test or yarn test)

PatrickG · 2020-06-26T12:36:29Z

input is not the only labelable element.
See https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#Form_labelable

skippednote · 2020-06-26T13:56:05Z

Thanks @PatrickG, I'm checking for all labelable items now.

Conduitry · 2020-08-05T16:38:56Z

This is warning is included in 3.24.1.

enjoythelive1 · 2021-04-20T11:36:58Z

src/compiler/compile/nodes/Element.ts

@@ -507,6 +518,16 @@ export default class Element extends Node {
 			}
 		}

+		if (this.name === 'label') {
+			const has_input_child = this.children.some(i => (i instanceof Element && a11y_labelable.has(i.name) ));


This ignores the possibility of elements having the role attribure.

fix(820): label has associated control

c623b33

fix(820): check for all labelable elements

81ce352

Conduitry merged commit 62ab75e into sveltejs:master Aug 5, 2020

taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020

add a11y-label-has-associated-control check (sveltejs#5074)

9829b11

enjoythelive1 reviewed Apr 20, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(820): label has associated control #5074

fix(820): label has associated control #5074

skippednote commented Jun 26, 2020

PatrickG commented Jun 26, 2020

skippednote commented Jun 26, 2020

Conduitry commented Aug 5, 2020

enjoythelive1 Apr 20, 2021

fix(820): label has associated control #5074

fix(820): label has associated control #5074

Conversation

skippednote commented Jun 26, 2020

Before submitting the PR, please make sure you do the following

Tests

PatrickG commented Jun 26, 2020

skippednote commented Jun 26, 2020

Conduitry commented Aug 5, 2020

enjoythelive1 Apr 20, 2021

Choose a reason for hiding this comment