feat: css unit handling for fly transition #6050
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to be able to give CSS unit parameter to transition fly function.
'fly' is the best candidate. It defines an absolute/arbitrary transformation while the others define rather a transformation relative to an existing div's style.
Units are quiet often left behind in a lot of js library, 'px' is not the only one :)
use:
<div transition:fly={{ y: 1, unit: 'em' }}></div>
Before submitting the PR, please make sure you do the following
Tests
npm test
and lint the project withnpm run lint