Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose svelte/ssr which have noop for lifecycle events #6416

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

tanhauhau
Copy link
Member

Fixes #6372

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I'm not sure if there's anything we need to do to document this either here or in the Rollup plugin PR?

@tanhauhau
Copy link
Member Author

Lgtm. I'm not sure if there's anything we need to do to document this either here or in the Rollup plugin PR?

Yes, sveltejs/rollup-plugin-svelte#186

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @dominikg needs to handle this, too, in the vite plugin

@dominikg
Copy link
Member

I think @dominikg needs to handle this, too, in the vite plugin

Indeed. thanks for alerting me.
I'll copy the approach in the rollup plugin MR, but it may get more complicated due to the fact that in vite we run both ssr and dom at the same time during dev.

@Conduitry
Copy link
Member

Released in 3.39.0.

dummdidumm added a commit that referenced this pull request Aug 24, 2021
Via #6416, lifecycle hooks became noops for SvelteKit. But onDestroy is said to be called suring SSR according to the docs.

Fixes #6676
@dummdidumm dummdidumm mentioned this pull request Aug 24, 2021
5 tasks
dummdidumm added a commit that referenced this pull request Aug 24, 2021
Via #6416, lifecycle hooks became noops for SvelteKit. But onDestroy is said to be called suring SSR according to the docs.

Fixes #6676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve svelte to a different module in SSR mode
5 participants