Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] check if click events are accompanied by key events #6652

Closed
wants to merge 1 commit into from
Closed

[feat] check if click events are accompanied by key events #6652

wants to merge 1 commit into from

Conversation

dsfx3d
Copy link
Contributor

@dsfx3d dsfx3d commented Aug 15, 2021

#820
Changes for the rule, click-events-have-key-events.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Changes for rule, click-events-have-key-events

Partly resolves #820
@dsfx3d dsfx3d changed the title check if click events are accompanied by key events [feat] check if click events are accompanied by key events Aug 15, 2021
@dsfx3d
Copy link
Contributor Author

dsfx3d commented Aug 15, 2021

Do I have to make any changes?

@tanhauhau
Copy link
Member

Closed in favor of #5073

I have added you in as Co-author, thank you for your contribution!

@tanhauhau tanhauhau closed this Sep 13, 2022
@dsfx3d
Copy link
Contributor Author

dsfx3d commented Sep 13, 2022

Thanks ☺️👍

@dsfx3d dsfx3d deleted the a11y-click-events-have-key-events branch October 6, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants