fix: var scope should not extend outside the reactive block #6800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaiVaibhav
changed the title
RaiVaibhav
force-pushed
the
fix/pr-6794
branch
from
987aa30
to
fa0bf1a
Compare
|
Hey @Conduitry whenever you are free please have a look at this PR, also let me know if it will need some change in the documentation. |
tanhauhau
requested changes
Apr 12, 2022
|
Hey, I will check the review and update the PR today 👍 , thank you for reviewing. |
RaiVaibhav
force-pushed
the
fix/pr-6794
branch
from
fa0bf1a
to
aa59e01
Compare
|
Hey, @tanhauhau updated the PR with the addressed review. |
|
Giving this the v4 label because strictly speaking it's a breaking change, some valid code that works now could be erroring then. |
|
@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
benmccann
changed the title
Instead of "both", which doesn't make sense at that point.
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
- upgrade to TypeScript 5 - upgrade @ampproject/remapping - remove obsolete workarounds --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
bump to rollup 3. Includes reworking the "treat those imports as external" a bit so that Rollup builds correctly but doesn't bundle some of the (now relative) imports --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6794
Before submitting the PR, please make sure you do the following
[feat],[fix],[chore], or[docs].Tests
npm testand lint the project withnpm run lint