Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] kebab case style directives with template causes syntax error #7123

Merged
merged 5 commits into from
Jan 12, 2022
Merged

[fix] kebab case style directives with template causes syntax error #7123

merged 5 commits into from
Jan 12, 2022

Conversation

ghostdevv
Copy link
Member

@ghostdevv ghostdevv commented Jan 12, 2022

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

This fixes #7122 and includes a new test as well

@ghostdevv ghostdevv changed the title [fix] style directives with template causes syntax error [fix] kebab case style directives with template causes syntax error Jan 12, 2022
@dummdidumm
Copy link
Member

dummdidumm commented Jan 12, 2022

Could you fix the more-dashes case @gtm-nayan mentioned in the conversation and enhance the test for that? Then we're good to go I think.

@ghostdevv
Copy link
Member Author

@dummdidumm yes! Just got a dm from @dominikg about that too 😄

@ghostdevv
Copy link
Member Author

@dummdidumm Should be all fixed now

@dummdidumm dummdidumm merged commit c67f8ef into sveltejs:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kebab case style directives with a template fails
3 participants