New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] support !important in style directive #7470

Closed

tanhauhau wants to merge 1 commit into sveltejs:master from tanhauhau:tanhauhau/gh-7365

Member

tanhauhau commented Apr 19, 2022 •

edited

Fixes #7365

Before submitting the PR, please make sure you do the following

Prefix your PR title with [feat], [fix], [chore], or [docs].
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with npm test and lint the project with npm run lint


          support !important in style directive

fc9032c

Antonio-Bennett commented Apr 20, 2022

Hey what do you think about this comment? #7365 (comment)
I agree that using a | like style:color|important={color} feels a lot more svelty

tanhauhau marked this pull request as draft

April 21, 2022 13:48

gtm-nayan mentioned this pull request

[feat] |important modifier for style directive #7489

Merged

8 tasks

Member Author

tanhauhau commented May 29, 2022

Close in favor of #7489

tanhauhau closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment