Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a11y no-noninteractive-element-interactions #8391

Merged
merged 15 commits into from Apr 14, 2023
Merged

feat: add a11y no-noninteractive-element-interactions #8391

merged 15 commits into from Apr 14, 2023

Conversation

ngtr6788
Copy link
Contributor

Reference to the a11y issue: #820.
As the title says, this PR adds the no-noninteractive-element-interactions rule.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@vercel
Copy link

vercel bot commented Mar 17, 2023

@ngtr6788 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@ngtr6788 ngtr6788 closed this Mar 20, 2023
@ngtr6788 ngtr6788 reopened this Mar 20, 2023
@dummdidumm dummdidumm added this to the 4.x milestone Mar 21, 2023
@dummdidumm dummdidumm changed the base branch from master to version-4 April 11, 2023 13:24
dummdidumm
dummdidumm approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit d1a9722 into sveltejs:version-4 Apr 14, 2023
11 of 12 checks passed
dummdidumm pushed a commit that referenced this pull request Apr 18, 2023
@ngtr6788 @dummdidumm
feat: add a11y no-noninteractive-element-interactions (#8391)
68bf3e8 
#820
@ngtr6788 ngtr6788 deleted the a11y-no-noninteractive-element-interactions branch April 26, 2023 01:40
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngtr6788 @dummdidumm @benmccann