-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix CI on Node 20 #8528
chore: fix CI on Node 20 #8528
Conversation
@baseballyama is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
Why do you think this is necessary? The CI appears to me to be passing on Node 20. For example: https://github.com/sveltejs/svelte/actions/runs/4751810813/jobs/8441389746 |
pnpm/pnpm#6424 I was having this exact issue with pnpm and Node 20 in other unrelated projects. It was apparently caused by something in node-fetch and was resolved in pnpm 8.3.1 by forking node-fetch. I'm not sure why CI was passing without it. Does that still build the compiler in one version of Node and then run tests in another? I seem to recall that happening at one point when we wanted to use a version of Rollup that didn't run on Node 8. |
Looking more closely at the GH action run you linked to, I do see some Node 18 floating around in the logs. I don't actually see Node 20 mentioned anywhere, but I haven't looked extremely closely. |
Yeah, this action uses Node v18.15.0. https://github.com/sveltejs/svelte/actions/runs/4751810813/jobs/8441389746#step:4:11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! No wonder we didn't see it on the CI. I sent a fix for that here: #8530
The other way of addressing this would be to drop support for Node 14 and then just use pnpm 8 everywhere. Node 14 will be EOL in a week, so that might be preferable
|
As I commented on #8530, I'm seeing the same issue on 7.32.0 locally as I am with 8 prior to 8.3.1. I suspect there's something being cached (either in the downloading or the installing of the packages) in GitHub actions that is concealing the issue. I would bet that if we tried upgrading any of the dependencies, we'd run into this same issue in CI in Node 20. |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
I think on Node20, we need to use pnpm@8.3.1.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests
npm test
and lint the project withnpm run lint