Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): parse let directive alias as pattern instead of expression #8653

Draft
wants to merge 2 commits into
base: svelte-4
Choose a base branch
from

Conversation

gtm-nayan
Copy link
Contributor

HEADS UP: BIG RESTRUCTURING UNDERWAY

The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler aswell. For that reason, please don't open PRs that are large in scope, touch more than a couple of files etc. In other words, bug fixes are fine, but feature PRs will likely not be merged.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@vercel
Copy link

vercel bot commented May 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
svelte-dev-2 ❌ Failed (Inspect) May 28, 2023 11:52am

@@ -438,8 +439,9 @@ function get_directive_type(name) {

/**
* @param {import('../index.js').Parser} parser
* @param {boolean} as_pattern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be optional since there's a default? (same below)

Suggested change
* @param {boolean} as_pattern
* @param {boolean} [as_pattern]

@benmccann benmccann added this to the 4.x milestone Jun 9, 2023
@benmccann benmccann deleted the branch svelte-4 June 20, 2023 20:45
@benmccann benmccann closed this Jun 20, 2023
@benmccann benmccann reopened this Jun 20, 2023
@benmccann benmccann changed the base branch from version-4 to master June 20, 2023 20:51
@benmccann benmccann removed this from the 4.x milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants