Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: never use html optimization for mustache tags in hydration mode #8744

Merged
merged 4 commits into from Jun 16, 2023

Conversation

dummdidumm
Copy link
Member

not sure how to add a test for this yet, as it needs to compilations, one for ssr one for client hydration

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev-2 ❌ Failed (Inspect) Jun 16, 2023 4:16pm

@dummdidumm dummdidumm added this to the 4.x milestone Jun 16, 2023
@benmccann
Copy link
Member

.svelte-kit/output/client/_app/immutable/nodes on version-4 is 179.1kB and on this branch is 179.0 kB. I didn't think it'd get smaller!

@dummdidumm
Copy link
Member Author

That's honestly surprising, since this change makes less things be matched by the data-svelte-h optimization - but maybe in this specific case it's actually smaller in the end because it results in less code?
Either way, gonna merge this 👍

@dummdidumm dummdidumm merged commit aa8cc5d into version-4 Jun 16, 2023
7 checks passed
@dummdidumm dummdidumm deleted the fix-hydration branch June 16, 2023 20:12
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants