Update launch.json #8837
Update launch.json #8837
Conversation
Improvements Made: Added the "webRoot" property to the browser configuration to specify the web root directory as the workspace folder. Modified the "program" property in the server configuration to use an absolute path for the start.js script. Added the "restart" property to the server configuration to enable automatic restarts. Set the "console" property to "integratedTerminal" for the server configuration to use an integrated terminal for debugging. These improvements aim to enhance the functionality and usability of the launch configurations. Adjust the paths and properties according to your project's structure and requirements.
|
Can you change the indentation back to tabs please? It's difficult to tell what this changes when almost every line has changed. |
| @@ -5,17 +5,19 @@ | |||
| "type": "chrome", | |||
| "request": "launch", | |||
| "name": "Playground: Browser", | |||
| "url": "http://localhost:10001" | |||
| "url": "http://localhost:10001", | |||
| "webRoot": "${workspaceFolder}" | |||
There was a problem hiding this comment.
I don't exactly know what this option is used for but from its description it sounds like it should point to the directory that the files are served from and pointing it to the workspace folder would be incorrect. Could you please explain what this does?
| }, | ||
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "runtimeArgs": ["--watch"], | ||
| "name": "Playground: Server", | ||
| "outputCapture": "std", | ||
| "program": "start.js", | ||
| "program": "${workspaceFolder}/packages/playground/start.js", |
There was a problem hiding this comment.
This is not necessary, it resolves using the cwd below.
| "cwd": "${workspaceFolder}/packages/playground", | ||
| "cascadeTerminateToConfigurations": ["Playground: Browser"] | ||
| "restart": true, | ||
| "console": "integratedTerminal" |
There was a problem hiding this comment.
This will make the output appear in the terminal instead of the debug console, is there any benefit to doing so?
|
@KARTHIK07GUPTA can you explain why each change was made? I.e. please explain what the behavior is before and after and why you prefer the new behavior. If there's no response we'll go ahead and close this PR |
Improvements Made:
Added the "webRoot" property to the browser configuration to specify the web root directory as the workspace folder. Modified the "program" property in the server configuration to use an absolute path for the start.js script. Added the "restart" property to the server configuration to enable automatic restarts. Set the "console" property to "integratedTerminal" for the server configuration to use an integrated terminal for debugging. These improvements aim to enhance the functionality and usability of the launch configurations. Adjust the paths and properties according to your project's structure and requirements.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint