Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle patterns in destructured literals #8871

Merged
merged 11 commits into from Jul 11, 2023

Conversation

gtm-nayan
Copy link
Contributor

fixes #8863

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@gtm-nayan gtm-nayan marked this pull request as ready for review June 29, 2023 10:11
@benmccann
Copy link
Member

Hmm. I have no idea why lint is failing due to some site error since merging in the latest changes from master. @PuruVJ have you ever seen this error before?

@PuruVJ
Copy link
Collaborator

PuruVJ commented Jul 8, 2023

That is happening because the get_contributors.js script, when trying to fetch from github, is getting an error response, which is failing in the Array.isArray check. Im sure its no problem, retriggering lint should make it go away

@gtm-nayan
Copy link
Contributor Author

Yeah, reran it a few minutes ago and the error went away.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm though it should probably get a final approval from someone with more svelte core experience

@benmccann benmccann requested a review from dummdidumm July 9, 2023 02:49
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@dummdidumm dummdidumm merged commit 20dac2a into master Jul 11, 2023
7 checks passed
@dummdidumm dummdidumm deleted the hoistability-destruct-literal branch July 11, 2023 16:02
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destructuring a props that has a primitive as default value gives a vague error
4 participants