Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transition slide not smooth with min height and min width #8907

Open
wants to merge 1 commit into
base: svelte-4
Choose a base branch
from

Conversation

xxkl1
Copy link
Contributor

@xxkl1 xxkl1 commented Jul 4, 2023

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

closes: #8533

transition slide will become not smooth with min-height and min-width.
https://svelte.dev/repl/90fdf9a3faa645aaa1e18201cf29e9cf?version=4.0.3

transition slide not smooth when with min height or min width.

I think we can set min-height or min-width to be 0 to keep slide smooth when run animation.

I didn't add a test case because I don't know how to test this case.

I'd be happy to add test cases, if any suggestions can be given.

@roberrrt-s
Copy link

Bumping for visibility, would love to see this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slide Transition should have min-height/width set to 0
3 participants