Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: claim svg tags in raw mustache tags correctly #8910

Merged
merged 1 commit into from Jul 4, 2023
Merged

Conversation

dummdidumm
Copy link
Member

fixes #8904

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm dummdidumm merged commit 35221c8 into master Jul 4, 2023
7 checks passed
@dummdidumm dummdidumm deleted the claim-svgs branch July 4, 2023 19:46
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
@gtm-nayan
Copy link
Contributor

gtm-nayan commented Jul 5, 2023

I'm confused about the fix, isn't this just changing the order of the arguments? Was it being generated in the compiler output with the wrong order?

@dummdidumm
Copy link
Member Author

The fix seems weird like that I agree. It fixes the bug because the c method that creates things invokes both HtmlTag and HtmlTagHydration with either true or false and means the svg param by that. The bug was that HtmlTagHydration expect that svg param as a second parameter, so as a result "is svg" always resulted in false. Switching params fixes it.

bleucitron pushed a commit to Svelte-Society-Fr/svelte that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{@html} is not hydrating properly SVG
2 participants