Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spreading attributes on option value attribute get's replaced by option's inner text #9125

Merged
merged 2 commits into from Sep 20, 2023
Merged

fix: spreading attributes on option value attribute get's replaced by option's inner text #9125

merged 2 commits into from Sep 20, 2023

Conversation

teobgeno
Copy link
Contributor

fixes #9107
Apart from the problem with the option the same happens with the textarea.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2023 •
edited

🦋 Changeset detected

Latest commit: e933dd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dummdidumm
dummdidumm approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.changeset/tricky-planets-rush.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 93b17c8 into sveltejs:master Sep 20, 2023
6 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Merged
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
@teobgeno @kelvinsjk
fix: spreading attributes on option value attribute get's replaced by…
c581b48 
… option's inner text (sveltejs#9125)

fixes sveltejs#9107
Apart from the problem with the option the same happens with the textarea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spreading attributes (containing value) on <option>, value attribute get's replaced by option's inner text
2 participants
@teobgeno @dummdidumm