Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: svelte.dev site scripts filepath generation #9273

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Coronon
Copy link
Contributor

@Coronon Coronon commented Sep 28, 2023

This small change fixes an issue when attempting to run the svelte.dev site locally on a windows machine:

Error: ENOENT: no such file or directory, mkdir '/C:/somepath/svelte/sites/svelte.dev/src/routes/_components/Supporters'

Notice the leading / in the path above, which comes from using .pathname directly instead of fileURLToPath.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

⚠️ No Changeset found

Latest commit: f355535

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann merged commit 9ffe07d into sveltejs:master Oct 4, 2023
7 checks passed
@Coronon Coronon deleted the fix/scripts branch October 4, 2023 10:10
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants