Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing svelte/transition functions #9391

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

wbhob
Copy link
Contributor

@wbhob wbhob commented Nov 12, 2023

Closes #9402

This PR adds back transitions that got lost in migration: blur, fly, scale, and draw, along with utility functions cubic_in_out and split_css_unit. Svelte v4 version for reference: https://github.com/sveltejs/svelte/blob/svelte-4/packages/svelte/src/runtime/transition/index.js

Copy link

vercel bot commented Nov 12, 2023

@wbhob is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Nov 12, 2023

⚠️ No Changeset found

Latest commit: f0947ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann added this to the 5.x milestone Nov 12, 2023
@trueadm
Copy link
Contributor

trueadm commented Nov 12, 2023

Just needs the formatting fixed on that module and we can merge! Thanks :)

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 4:36pm

@trueadm trueadm merged commit 1daadc3 into sveltejs:main Nov 13, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: transitions missing
3 participants