Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing context of svelte.js for validation #9394

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Nov 12, 2023

fix: https://svelte-5-preview.vercel.app/#H4sIAAAAAAAAE2WOywqDMBBFf2VIF7ZQdK-2ULrpPzRdSIw0oknIjH0g-fcapSrtbu7lcub0rFKNRJZee6aLVrKUnaxle0ZvGwI-ZENyyGg6J0KTo3DK0pFrTqq1xhH0cDadptI8NXionGkhihPx7eIJEtcYZVznyQLQFzWgW1OqSsmSpeQ66fezyS9h0apxrSRfo4ZoCsSVSh8UN0jSZuESRuPwQJBx21DupgEnuiuMxx0cYJ574NrDv97NfwAO2LqkNAEAAA==

I wanted to add a test with svelte.js but could not figure out how. Perhaps I need to update test runner, is that correct?

Svelte compiler rewrite

Please note that the Svelte codebase is currently being rewritten. Thus, it's best to hold off on new features or refactorings for the time being.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 12, 2023

🦋 Changeset detected

Latest commit: 0168e58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 12, 2023

@baseballyama is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@Rich-Harris Rich-Harris merged commit 19f84ca into sveltejs:main Nov 15, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants