Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Show AST on Svelte5 Playground #9440

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Nov 14, 2023

I wanted to see the AST when I do something for ESLint plugin.

image

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: 2090f72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 14, 2023

@baseballyama is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm
Copy link
Member

Is that the new AST that's shown? Is the idea to rewrite the eslint plugin internals for the new AST?

@baseballyama
Copy link
Member Author

baseballyama commented Nov 14, 2023

Is that the new AST that's shown? Is the idea to rewrite the eslint plugin internals for the new AST?

ota-meshi worked on it at the same time as I did, but I wanted to check the AST to fix this part.
https://github.com/sveltejs/svelte-eslint-parser/pull/421/files#diff-cd63d3422f13c0483f8cc061f0c5a1861cf5bf3d6fc2aee8fb193dc44ab97ecfR202

And I set { modern: true } so this is new AST.

https://github.com/sveltejs/svelte/pull/9440/files#diff-e3940da181ae52e57bcd531bbf13e7047cc89f479cd22a7eccfcb7f72b23ec05R69

At the moment svelte-eslint-parser uses Svelte4 compatible ASTs, but it is easy to change the flags on my own machine if I want to see the ASTs if this PR is there.

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 0:01am

@dummdidumm dummdidumm merged commit a6fdc47 into sveltejs:main Nov 14, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants