Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support dynamic attributes containing call expressions #9443

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 14, 2023

Fixes #9403. We weren't taking into account the containment of call expressions logic before.

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: 95eb6db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 0:22am

@dummdidumm dummdidumm merged commit da37c92 into main Nov 14, 2023
8 checks passed
@dummdidumm dummdidumm deleted the fix-dynamic-attr branch November 14, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Attributes not being updated correctly with functions
2 participants