Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle action member expression keys #9464

Closed
wants to merge 2 commits into from

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 15, 2023

Fixes #9445. Ensures we properly handle action member expression keys that are not valid JS identifiers.

Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: 00de58f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 11:21am

@trueadm
Copy link
Contributor Author

trueadm commented Nov 15, 2023

Although #9462 might be a better fix.

@dummdidumm
Copy link
Member

Oh, just saw this PR now, sorry - I already merged #9462, so closing in favor of that.

@dummdidumm dummdidumm closed this Nov 15, 2023
@dummdidumm dummdidumm deleted the fix-action-property-key branch November 15, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Actions from object properties are not properly escaped
2 participants