Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle intro global transition propagation correctly #9515

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 17, 2023

There was a bug with how we propagate global intro transitions – otherwise we end up never clearing down the effects and content gets duplicated. This fixes that.

Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: 09e9d26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 6:22pm

@trueadm trueadm merged commit f886bc1 into main Nov 17, 2023
8 checks passed
@trueadm trueadm deleted the dont-propagate-intro-global branch November 17, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant