-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: more signal fine-tuning #9531
Conversation
🦋 Changeset detectedLatest commit: f8b892e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cfdf865
to
16d84e4
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
value: V; | ||
}; | ||
|
||
export type ComputationSignal<V = unknown> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an extension of the Signal interface? If so, should we make these interfaces so we can use extends
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no Signal
interface. Signal
is a union of the two shapes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant SourceSignal
, which looks like a strict subset of ComputationSignal
Rather than having a single monomorphic signal object, it can be just as fast two have two object shapes. This also reduces memory usage as the source signal shape can be cheaper.