chore: rename internal object properties #9532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7599969 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chore: rename internal object properties order properties and add comments add missing remove_in_transitions
trueadm
force-pushed
the
internal-property-rename
branch
from
61ff5ff
to
da1e994
Compare
dummdidumm
reviewed
Nov 18, 2023
Is it? For 4ms? And 0.7kb? I don't think it is. Svelte 5 is in JS instead of TS so jump-to-definition makes sense. For the developer experience. This undoes that, no? |
|
@sisou Those are pretty big figures for a hello world SvelteKit app that starts at 9kb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all our internal object properties to single characters. This improves code-size, parse time and also improves runtime performance across the board. It just makes the coder harder to read, so I've added comments throughout that labels what they are in most cases. I've likely missed some obvious ones though as there's so many properties going on here.
This saves 0.7kb min+gzip and improves parse time on the default SvelteKit app startup by 4ms!