Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle spreads within static strings #9554

Merged
merged 1 commit into from Nov 20, 2023
Merged

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 20, 2023

Previously, if a part of the template was determined be be optimizable using innerHTML, it would error if there's a spread on an attribute.
I escaped the attribute values just to be extra sure although these can only be coming from purely static content anyway.

Discovered this while working on image optimization in SvelteKit.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Previously, if a part of the template was determined be be optimizable using innerHTML, it would error if there's a spread on an attribute
Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: 4b48526

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 9b33413 into svelte-4 Nov 20, 2023
8 checks passed
@dummdidumm dummdidumm deleted the static-spread branch November 20, 2023 14:20
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants