Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add children to element typings #9679

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: add children to element typings #9679

merged 2 commits into from
Nov 28, 2023

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 28, 2023

Add this here so that libraries doing $props<HTMLButtonAttributes>() don't need a separate interface
fixes #sveltejs/language-tools#2218

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Add this here so that libraries doing `props$<HTMLButtonAttributes>()` don't need a separate interface
fixes #sveltejs/language-tools#2218
Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: dc4bf53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 9:40am

@Rich-Harris Rich-Harris merged commit f9ba528 into main Nov 28, 2023
9 checks passed
@Rich-Harris Rich-Harris deleted the children-type branch November 28, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants