fix: improve template text node serialization #9722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d67e069 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fix: improve template text node serialization
trueadm
force-pushed
the
improve_template_text_node_serialization
branch
from
05b6f92
to
d67e069
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rich-Harris
added a commit
that referenced
this pull request
Nov 30, 2023
This reverts commit 2fa0644.
Rich-Harris
added a commit
that referenced
this pull request
Nov 30, 2023
5 tasks
Rich-Harris
added a commit
that referenced
this pull request
Jan 31, 2024
Rich-Harris
added a commit
that referenced
this pull request
Jan 31, 2024
* Revert "fix: improve template text node serialization (#9722)" This reverts commit 2fa0644. * regression test for #9722 * add back failing test * better test * create text nodes during hydration * partial fix * partial fix * remove nasty brittle logic * simplify * refactor * rename * thunkify * fix * add back changeset * changeset * lint --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9695