fix: tweak invalid dollar prefix rules around function args

[trueadm]

Fixes #9786.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4ce0a56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
svelte-5-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 5, 2023 9:13pm

[brunnerh]

Isn't that the wrong fix? The component is not in runes mode and as has been noted by the author of the issue:

If I remove the context=module, the code works.

I suspect that checks are being applied to the context script that should not have been applied in the first place.

[trueadm]

@brunnerh In context module, the function_depth is 0, in components it is 1. So if you're inside a function in a component, it will be 2. That's why it worked with the code change.

However, changing the depth isn't the right fix here, the right fix is knowing if it's a function argument and if so skipping the error in those cases. Which is far more resilient than checking depths.

[brunnerh]

Oh, then that makes sense, thank you.