Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transition parameters are not reactive #9836

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Conversation

sockmaster27
Copy link
Contributor

@sockmaster27 sockmaster27 commented Dec 7, 2023

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: 84023e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 7, 2023

@sockmaster27 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@sockmaster27 sockmaster27 changed the title fix: transition functions are evaluated too early fix: transition parameters are not reactive Dec 8, 2023
@sockmaster27
Copy link
Contributor Author

Now the props should only be evaluated when the transition is initialized.
Would this be sound?

@sockmaster27 sockmaster27 marked this pull request as ready for review December 8, 2023 12:01
Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 4:28pm

@trueadm
Copy link
Contributor

trueadm commented Dec 27, 2023

This needs a changeset :)

@trueadm trueadm merged commit 8a013c4 into sveltejs:main Dec 27, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants