Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GamepadEventHandler type #9861

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

ntsd
Copy link
Contributor

@ntsd ntsd commented Dec 8, 2023

Add GamepadEventHandler type for window.addEventListener gamepadconnected and gamepaddisconnected

Ref: https://developer.mozilla.org/en-US/docs/Web/API/GamepadEvent

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: b049d64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 8, 2023

@ntsd is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm
Copy link
Member

Thank you! Do you need this in Svelte 4 as well? Because this PR targets the Svelte 5 branch.

@ntsd
Copy link
Contributor Author

ntsd commented Dec 8, 2023

Thank you! Do you need this in Svelte 4 as well? Because this PR targets the Svelte 5 branch.

Yes, but not sure where to add. Oh thank you I just saw svelte-4

@dummdidumm dummdidumm changed the base branch from main to svelte-4 December 8, 2023 15:02
@dummdidumm dummdidumm changed the base branch from svelte-4 to main December 8, 2023 15:02
@dummdidumm
Copy link
Member

dummdidumm commented Dec 8, 2023

The Svelte 4 branch is svelte-4. You need to make the commit against that (but keep this one open, we need one PR for each branch).
Also, please add a changeset using npx changeset

Add GamepadEventHandler type for window.addEventListener `gamepadconnected` and `gamepaddisconnected`
@ntsd ntsd changed the title feat: add gamepad event type feat: add GamepadEventHandler type Dec 8, 2023
@ntsd
Copy link
Contributor Author

ntsd commented Dec 8, 2023

The Svelte 4 branch is svelte-4. You need to make the commit against that (but keep this one open, we need one PR for each branch). Also, please add a changeset using npx changeset

Done, ready for review.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Remember to create the same PR (minus the ongame... variants) again the svelte-4 branch.

.changeset/late-crabs-lay.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit acf7310 into sveltejs:main Dec 8, 2023
6 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
@ntsd ntsd mentioned this pull request Dec 8, 2023
5 tasks
@ntsd
Copy link
Contributor Author

ntsd commented Dec 8, 2023

Thank you! Remember to create the same PR (minus the ongame... variants) again the svelte-4 branch.

Thank you, Link to the Svelte 4 PR #9864.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants